Fixed an i18n issue #2332
Merged
Fixed an i18n issue #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kerwin Bryant <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2332 +/- ##
============================================
+ Coverage 20.81% 20.83% +0.02%
Complexity 1153 1153
============================================
Files 412 412
Lines 17522 17522
Branches 2311 2311
============================================
+ Hits 3647 3651 +4
+ Misses 13466 13462 -4
Partials 409 409 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
hertzbeat/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java
Line 384 in 712c541
hertzbeat/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java
Line 521 in 712c541
hertzbeat/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java
Line 590 in 712c541
hertzbeat/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java
Line 642 in 712c541
From the above four lines of code, we can see that the [app] in the list data is all in lower-case;
Therefore, there will be a problem when the front-end tries to obtain i18n using an unprocessed (not uniformly converted to lower-case) [app].
hertzbeat/web-app/src/app/routes/alert/alert-setting/alert-setting.component.html
Line 112 in 712c541
Checklist
Add or update API